Use chrono to detect local timezone thread-safely #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techcable
force-pushed
the
fix/localtime-thread-safety
branch
from
4465f02 to
4c37f20
Compare
|
The |
Techcable
force-pushed
the
fix/localtime-thread-safety
branch
2 times, most recently
from
70cdb68 to
d2df947
Compare
As discussed in PR slog-rs#44, the 'time' crate fails timezone detection in the presence of multiple threads, because the underlying POSIX function localtime_r is not thread safe. In order to avoid these thread-safety issues, we use the chrono crate. It avoids system libraries and reimplements timezone detection from scratch. Thanks to @yaozongyou for suggesting this fix. There are two improvements that could be made to reduce dependency bloat: - Only enable this on unix systems - Switch to chono entirely. However, this fix is sufficient to avoid the bug and that is the priority. It is possible that the optimizer is smart enough to remove all chrono code except the localtime detection functionality. In that case, switching from time to chrono could increase bloat by pulling in two copies of time formatting code. Tests/benchmarks are needed to determine the best approach.
Techcable
force-pushed
the
fix/localtime-thread-safety
branch
from
d2df947 to
42630e4
Compare
|
This is important enough to warrant a patch release. It should not wait for 2.10. |
|
Merged in 835561b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #44, the 'time' crate fails timezone detection
in the presence of multiple threads, because the underlying
POSIX function localtime_r is not thread safe.
In order to avoid these thread-safety issues, we use the chrono crate.
It avoids system libraries and reimplements timezone detection from scratch.
Thanks to @yaozongyou for suggesting this fix.
There are two improvements that could be made to reduce dependency bloat:
However, this fix is sufficient to avoid the bug and that is the priority.
It is possible that the optimizer is smart enough to remove all chrono code
except the localtime detection functionality.
In that case, switching from time to chrono could increase bloat
by pulling in two copies of time formatting code.
Tests/benchmarks are needed to determine the best approach.
This superceeds PR #44.